Re: warning on geometry

["Mark M. Ito" <marki@jlab.org>]

Thanks Dave!

David Lawrence wrote:
>
> Hi Mark,
>
>    It was changed about 1.5 hours ago in revision 4384. Here is the 
> log message:
>
> Author: davidl
> Date: 2008-10-21 15:02:43 -0400 (Tue, 21 Oct 2008)
> New Revision: 4384
>
> Modified:
>   trunk/src/libraries/CDC/DCDCTrackHit_factory.h
> Log:
> Changed the value of CDC_MAX_RINGS from 25 to 24. This should have 
> been done back when revision 4147 was committed. The only affect this 
> should have is to get rid of the warning message at program start up.
>
>
> Regards,
> -David
>
> Mark M. Ito wrote:
>> Beni,
>>
>> I'm finding in DCDCTrackHit_factory.h:
>>
>> #define CDC_MAX_RINGS 25
>>
>> in the current version. Is this not OK? OK? Or not?
>>
>>  -- Mark
>>
>> Beni Zihlmann wrote:
>>> Hi Marc,
>>> the geometry file you sent me is the current one with 24 layers in 
>>> the CDC.
>>> so there is no layer 25 and therefore the warning must be a problem in
>>> the recsontruction code somewhere. It could be serious or not.
>>>
>>> cheers,
>>> Beni
>>>
>>>
>>>> Beni,
>>>>
>>>> I have three versions in the tree:
>>>>
>>>> ./programs/Simulation/hdds/hddsGeant3.F
>>>> ./programs/Simulation/HDGeant/hddsGeant3.F
>>>> ./programs/Utilities/geantbfield2root/hddsGeant3.F
>>>>
>>>> but I should mention that I did not generate this data, in case 
>>>> that is relevant. I have attached the one in
>>>> ./programs/Simulation/HDGeant/ .
>>>>
>>>>  -- Mark
>>>>
>>>> Beni Zihlmann wrote:
>>>>> Hi Mark,
>>>>> can you send me the hddsGeant3.F file you are using? this one 
>>>>> might be obsolete.
>>>>> cheers,
>>>>> Beni
>>>>>> Offline people,
>>>>>>
>>>>>> Getting the following warning in a late-ish version of code:
>>>>>>
>>>>>> DCDCTrackHit_factory.cc:123 Invalid value for CDC ring (25) 
>>>>>> should be 1-24 inclusive!
>>>>>>
>>>>>> Should I be worried?
>>>>>>
>>>>>>  -- Mark
>>>>>>
>>>>>
>>>
>